-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't set court='scotus' for South Carolina citations #84 #105
base: main
Are you sure you want to change the base?
Conversation
@mlissner I'm sorry, I don't understand.
Can you please give me more info about what needs to be done here? |
Linters are programs that check your work to make sure it's clean and pretty and using best practices. We have a few of them that were in Github Actions, but we didn't have a good process for developers to actually run them, so I just added a dev dependency for pre-comit to this branch. We use this in most of our other projects, so it seems reasonable to use it here too. After adding it, I ran it, it cleaned up and highlighted a few problems with your code, which I fixed for you. So this is ready for review again, but I'll wait for Jack to see if he wants to look at it. If not, I'll jump back in. |
Ok, I understand on the linting. I guess I'm so used to golint autoliniting my code that I forgot python doesn't do this automatically. So for future reference, is there a particular process I should use prior to committing? |
If you run |
This addresses issue #84. The issue was caused because SC is treated differently than S.C. when searching and scotus is the default return result. Since all court strings are unique with or without punctuation, stripping all punctuation and converting to the same case allows for an exact comparison instead of the "startswith" comparison that was previously being used.